Re: [PATCH 14/37] clk: renesas: rzg2l: use u32 for flag and mux_flags
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2023-09-14 13:29:57
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-mmc, linux-renesas-soc, linux-serial, lkml
Hi Claudiu, On Tue, Sep 12, 2023 at 6:52 AM Claudiu [off-list ref] wrote:
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> flag and mux_flags are intended to keep bit masks. Use u32 type for it. Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/drivers/clk/renesas/rzg2l-cpg.h +++ b/drivers/clk/renesas/rzg2l-cpg.h@@ -92,8 +92,8 @@ struct cpg_core_clk { unsigned int conf; const struct clk_div_table *dtable; const char * const *parent_names; - int flag; - int mux_flags; + u32 flag;
"flag" is used for several purposes, which expected different types:
- clk_init_data.flags is unsigned long,
- The clk_divider_flags parameter of clk_hw_register_divider_table() is u8,
- The clk_divider_flags parameter of __clk_hw_register_divider() is u8,
- The flags parameter of __devm_clk_hw_register_mux() is unsigned long.
+ u32 mux_flags;
Actually the clk_mux_flags parameter of __devm_clk_hw_register_mux() is u8.
int num_parents; };
I guess u32 is fine for all.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel