Hi Shravan,

On Fri, Feb 24, 2023 at 10:02:51AM +0000, Shravan.Chippa@microchip.com wrote:

Hi Sakari,

quoted

-----Original Message-----
From: Sakari Ailus <sakari.ailus@iki.fi>
Sent: 22 February 2023 05:03 PM
To: shravan Chippa - I35088 <redacted>
Cc: Conor Dooley - M52691 <Conor.Dooley@microchip.com>;
paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
mchehab@kernel.org; robh+dt@kernel.org;
krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
linux-imx@nxp.com; linux-media@vger.kernel.org; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; jacopo.mondi@ideasonboard.com; Battu
Prakash Reddy - I30399 [off-list ref]
Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth
mode

EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe

On Wed, Feb 22, 2023 at 10:20:56AM +0000, Shravan.Chippa@microchip.com
wrote:

quoted

Hi Sakari,

quoted

-----Original Message-----
From: Sakari Ailus <sakari.ailus@iki.fi>
Sent: 22 February 2023 03:36 PM
To: Conor Dooley - M52691 <Conor.Dooley@microchip.com>
Cc: shravan Chippa - I35088 <redacted>;
paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
mchehab@kernel.org; robh+dt@kernel.org;
krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
s.hauer@pengutronix.de; kernel@pengutronix.de;

festevam@gmail.com;

quoted

quoted

linux-imx@nxp.com; linux-media@vger.kernel.org; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; Jacopo Mondi
[off-list ref]; Battu Prakash Reddy - I30399
[off-list ref]
Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower
bandwidth mode

EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe

On Wed, Feb 22, 2023 at 12:03:10PM +0200, Sakari Ailus wrote:

quoted

On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:

quoted

On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:

quoted

On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:

quoted

From: Shravan Chippa <redacted>

quoted

quoted

@@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct

v4l2_subdev *sd,

quoted

quoted

quoted

quoted

        struct v4l2_subdev_format fmt = { 0 };

        fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY :

V4L2_SUBDEV_FORMAT_ACTIVE;

quoted

quoted

quoted

quoted

-       imx334_fill_pad_format(imx334, &supported_mode, &fmt);
+       imx334_fill_pad_format(imx334, &supported_modes[0],
+ &fmt);

Now that there are multiple modes supported, this would appear
to get the width, height as well as the other fields (apart
from mbus
code) from the first mode.

Is this statement supposed to be a request to change something,
or just a throwaway comment? It's a little hard for me to
understand your intention here, sorry.

Just pointing to what looks like a bug.

Ah, my bad. Please ignore the comment.

This is indeed about init_cfg(), not s_fmt().

I will try to fix init_cfg()

There's no problem with it. Please ignore my original comment on this.

Just checking, Do I need to do any modifications or the current code is fine?

The init_cfg() implementation is, but please see my other e-mail.

-- 
Regards,

Sakari Ailus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel