On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:

On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:

quoted

From: Shravan Chippa <redacted>

quoted

@@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev *sd,
 	struct v4l2_subdev_format fmt = { 0 };
 
 	fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
-	imx334_fill_pad_format(imx334, &supported_mode, &fmt);
+	imx334_fill_pad_format(imx334, &supported_modes[0], &fmt);

Now that there are multiple modes supported, this would appear to get the
width, height as well as the other fields (apart from mbus code) from the
first mode.

Is this statement supposed to be a request to change something, or just
a throwaway comment? It's a little hard for me to understand your
intention here, sorry.

quoted

 
 	return imx334_set_pad_format(sd, sd_state, &fmt);
 }