Thread (17 messages) 17 messages, 4 authors, 2023-02-01

Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT

From: Nikita Shubin <nikita.shubin@maquefel.me>
Date: 2023-01-25 08:45:17
Also in: linux-gpio, lkml

Hello Arnd!

On Tue, 17 Jan 2023 11:15:20 +0100
"Arnd Bergmann" [off-list ref] wrote:
On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:
quoted
+#ifdef CONFIG_OF
+static const struct of_device_id ep93xx_gpio_match[] = {
+	{ .compatible = "cirrus,ep93xx-gpio" },
+	{ /* end of table */ },
+};
+MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
+#endif
+
 static struct platform_driver ep93xx_gpio_driver = {
 	.driver		= {
 		.name	= "gpio-ep93xx",
+		.of_match_table = ep93xx_gpio_match,
 	},
 	.probe		= ep93xx_gpio_probe,  
The #ifdef here is wrong and will cause a build failure because
of the unconditional reference to the variable.

Just remove the #ifdef/#endif.
Sorry about that - i remember that i should drop it everywhere, which
did for all but ep93xx-gpio, i am dropping match currently, as it will
produce a warning without dt-bindings documentation, it will be
introduced together with the rest of series.
    Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help