Thread (17 messages) 17 messages, 4 authors, 2023-02-01

Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT

From: Bartosz Golaszewski <hidden>
Date: 2023-01-18 14:35:27
Also in: linux-gpio, lkml

On Tue, Jan 17, 2023 at 11:08 AM Nikita Shubin
[off-list ref] wrote:
This converts ep93xx SOC gpio into device tree driver:
- dropped banks and legacy defines
- split AB IRQ and make it shared

We are relying on IRQ number information A, B ports have single shared
IRQ, while F port have dedicated IRQ for each line.

Also we had to split single ep93xx platform_device into multiple, one
for each port, without this we can't do a full working transition from
legacy platform code into device tree capable:

- all GPIO_LOOKUP were change to match new chip namings
- add lookup table for leds

Fixes: 482c27273f52 ("ARM: ep93xx: renumber interrupts")
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Reviewed-by: Linus Walleij <redacted>
---
rfc->v0
Linus Walleij:
- dropped chip-labels
- rebase on the top of your leds patch:
https://lore.kernel.org/linux-arm-kernel/20230111132210.134478-1-linus.walleij@linaro.org/T/ (local)
- i am converting to immutable after this patch, otherwise it will
  require a fix wich is very similiar to this patch

Hope changes are not that significant so i can still apply Rb tag.
---
 arch/arm/mach-ep93xx/core.c          | 129 +++++++++-
 arch/arm/mach-ep93xx/edb93xx.c       |   2 +-
 arch/arm/mach-ep93xx/simone.c        |   4 +-
 arch/arm/mach-ep93xx/ts72xx.c        |   4 +-
 arch/arm/mach-ep93xx/vision_ep9307.c |  10 +-
 drivers/gpio/gpio-ep93xx.c           | 350 +++++++++++----------------
 6 files changed, 265 insertions(+), 234 deletions(-)
This has a Fixes tag but it's a rather big commit. I hope this is not
meant to be backported to stable branches? Doesn't look like stable
material to me.

Could you change the order of the patches so that we can send the
immutable irqchip conversion for stable?

Bart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help