Re: [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2022-12-05 14:22:08
Also in:
linux-devicetree, linux-mediatek, linux-spi, lkml
Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
Add optional nfi_hclk which needed for MT7986. Signed-off-by: Xiangsheng Hou <redacted>
Is there any operation for which you need NFI_HCLK enabled, but at the same time PAD_CLK and/or NFI_CLK can be disabled? If NFI_HCLK and NFI_CLK must always be ON at the same time, adding this clock to spi-mtk-snfi.c is *not* an optimal way of doing things: you can, at this point, set NFI_HCLK as parent of NFI_CLK in the MT7986 clock driver instead, without making any addition to this driver at all. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel