Re: [PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin
From: Christoph Hellwig <hch@lst.de>
Date: 2022-11-09 06:28:27
Also in:
asahi, linux-nvme
On Wed, Nov 09, 2022 at 04:58:46AM +0200, Sagi Grimberg wrote:
quoted
@@ -2774,8 +2775,6 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl) nvme_dbbuf_dma_free(dev); nvme_free_tagset(dev); - if (dev->ctrl.admin_q) - blk_put_queue(dev->ctrl.admin_q);Is the check here valid? meaning can we get here with a NULL admin_q?
Yes, the admin queue is only set in the middle of nvme_reset_work, and for errors before that we can get here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel