Thread (40 messages) 40 messages, 6 authors, 2022-11-13

Re: [PATCH 01/12] nvme-pci: don't call nvme_init_ctrl_finish from nvme_passthru_end

From: Christoph Hellwig <hch@lst.de>
Date: 2022-11-09 06:27:16
Also in: asahi, linux-nvme

[note to self: the subject should say nvme instead of nvme-pci]

On Wed, Nov 09, 2022 at 04:55:47AM +0200, Sagi Grimberg wrote:
quoted
nvme_passthrough_end can race with a reset, so we should not call
nvme_init_ctrl_finish from here.  Instead just log that the controller
capabilities might have changed.
Can you explain here what is the problem caused by calling this from
here?
I'll add it to the next version:

 - stores to the cels xarray can race
 - the new opal initialization can race

and in general it just updates random controller fields without
a reset, which I'm worried about hitting completely untested code.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help