On 2022/11/23 22:12, Krzysztof Kozlowski wrote:

[ EXTERNAL EMAIL ]

On 23/11/2022 14:23, Yu Tu wrote:

quoted

quoted

quoted

../patch_clk_v5_1122/0004-arm64-dts-meson-add-S4-Soc-Peripheral-clock-controll.patch
has no obvious style problems and is ready for submission.

This is a checkpatch output. I am talking about DTS broken. dtc should
warn you.

Do you mean I will have wraning in compiling?
I actually compiled without warning.
ccf$ make ARCH=arm64 dtbs -j12
    DTC     arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dtb

Nope:

../arch/arm64/boot/dts/amlogic/meson-s4.dtsi:105.35-127.6: Warning
(unit_address_vs_reg): /soc/apb4@fe000000/clock-controller: node has a
reg or ranges property, but no unit name

Test your patches better before using reviewers time for trivial
compile-time fixes. The same rules for C code apply for DTS.

Like this:
	clkc_periphs: clock-controller@0 { 

                     compatible = "amlogic,s4-peripherals-clkc"; 

                     reg = <0x0 0x0 0x0 0x49c>;
You mean it should be, right?

Best regards,
Krzysztof

.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel