Re: [v4 3/5] dt-bindings: hwmon: Add bindings for aspeed tach controller
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-23 08:33:32
Also in:
linux-aspeed, linux-devicetree, linux-doc, linux-hwmon, linux-pwm, lkml
On 23/11/2022 07:16, Billy Tsai wrote:
Add the aspeed tach device bindings which should be the child-node of pwm-tach mfd.
Subject: drop second, redundant "bindings".
quoted hunk ↗ jump to hunk
Signed-off-by: Billy Tsai <redacted> --- .../bindings/hwmon/aspeed,ast2600-tach.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yamldiff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml new file mode 100644 index 000000000000..f42114f8e3c2 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml@@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2021 Aspeed, Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-tach.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Ast2600 Tach controller + +maintainers: + - Billy Tsai <billy_tsai@aspeedtech.com> + +description: | + The Aspeed Tach controller can support upto 16 fan input.
Same comments as before. When you receive feedback about something, please correct it everywhere, not only in one place.
+ This module is part of the ast2600-pwm-tach multi-function device. For more + details see ../mfd/aspeed,ast2600-pwm-tach.yaml. + +properties: + compatible: + enum: + - aspeed,ast2600-tach
Missing blank line.
+patternProperties: + "^fan@[a-z0-9]+$": + type: object
Missing description. But more important - why do you have such child nodes? Your example does not have them. What's the point? Do you expect different number of fans per one device (one compatible)?
+ properties: + reg: + description: + The tach channel used for this node. + maxItems: 1
Missing blank line.
+ required: + - reg + +required: + - compatible + +additionalProperties: false
Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel