Re: [v4 2/5] dt-bindings: pwm: Add bindings for aspeed pwm controller
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-23 08:30:19
Also in:
linux-aspeed, linux-devicetree, linux-doc, linux-hwmon, linux-pwm, lkml
On 23/11/2022 07:16, Billy Tsai wrote:
Add the aspeed pwm device bindings which should be the child-node of pwm-tach mfd.
Subject: drop second, redundant "bindings".
quoted hunk ↗ jump to hunk
Signed-off-by: Billy Tsai <redacted> --- .../bindings/pwm/aspeed,ast2600-pwm.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yamldiff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml new file mode 100644 index 000000000000..68a60fc73902 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml@@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2021 Aspeed, Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Ast2600 PWM controller + +maintainers: + - Billy Tsai <billy_tsai@aspeedtech.com> + +description: | + The Aspeed PWM controller supports up to 16 PWM outputs. + This module is part of the ast2600-pwm-tach multi-function device. For more + details see ../mfd/aspeed,ast2600-pwm-tach.yaml. + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + enum: + - aspeed,ast2600-pwm + + "#pwm-cells": + const: 3
Blank line.
+patternProperties: + "^pwm@[a-z0-9]+$": + description: Set extend properties for each pwm channel.
Description is not a correct sentence. Description explains the hardware property you have here.
+ type: object + properties: + reg: + description: + The pwm channel index. + maxItems: 1 + + aspeed,wdt-reload-enable: + type: boolean + description: + Enable the function of wdt reset reload duty point. + + aspeed,wdt-reload-duty-point: + description: + Define the duty point after wdt reset, 0 = 100% + minimum: 0 + maximum: 255
Why maximum is 255? Why 0=100%? 0 should be equal to 0 and maximum to some maximum value (e.g. 100%). If these are percents, use appropriate units. If these are not - what are these? You need a $ref in such case.
+ required: + - reg + +required: + - compatible + +additionalProperties: false
Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel