Re: [PATCH v1 09/17] drm/mediatek: hdmi: add connector flag
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2022-09-20 10:40:22
Also in:
dri-devel, linux-clk, linux-devicetree, linux-mediatek, linux-phy, lkml
Il 19/09/22 18:56, Guillaume Ranquet ha scritto:
quoted hunk ↗ jump to hunk
Add a flag to indicate support for an external connector Signed-off-by: Guillaume Ranquet <redacted>diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c index 86653ebaacfd..30407603d693 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c@@ -199,20 +199,22 @@ int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, struct platform_device *pdev, goto put_device; } - remote = of_graph_get_remote_node(np, 1, 0); - if (!remote) { - ret = -EINVAL; - goto put_device; - } - - if (!of_device_is_compatible(remote, "hdmi-connector")) { - hdmi->next_bridge = of_drm_find_bridge(remote); - if (!hdmi->next_bridge) { - dev_err(dev, "Waiting for external bridge\n"); - of_node_put(remote); - ret = -EPROBE_DEFER; + if (hdmi->conf->has_connector) {
If MT8195's DPI uses the internal HDMI->DP converter, I say that the external DP has HDMI input and DP output. Logically, you can't have a HDMI port that's connected to nothing. Please, rethink this change. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel