[AMD Official Use Only - General]

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Tuesday, September 6, 2022 11:17 PM
To: Gupta, Nipun <Nipun.Gupta@amd.com>
Cc: gregkh@linuxfoundation.org; eric.auger@redhat.com;
devicetree@vger.kernel.org; linux-kbuild@vger.kernel.org;
jeffrey.l.hugo@gmail.com; maz@kernel.org; Gupta, Puneet (DCG-ENG)
[off-list ref]; Michael.Srba@seznam.cz; cohuck@redhat.com;
will@kernel.org; masahiroy@kernel.org; mchehab+huawei@kernel.org;
joro@8bytes.org; okaya@kernel.org; alex.williamson@redhat.com;
song.bao.hua@hisilicon.com; jgg@nvidia.com; mani@kernel.org; linux-
kernel@vger.kernel.org; robin.murphy@arm.com; robh+dt@kernel.org;
krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; f.fainelli@gmail.com;
jgg@ziepe.ca; kvm@vger.kernel.org; Agarwal, Nikhil
[off-list ref]; Anand, Harpreet [off-list ref];
yishaih@nvidia.com; linux-arm-kernel@lists.infradead.org; git (AMD-Xilinx)
[off-list ref]; saravanak@google.com; Radovanovic, Aleksandar
[off-list ref]; Simek, Michal
[off-list ref]; ndesaulniers@google.com
Subject: Re: [RFC PATCH v3 1/7] dt-bindings: bus: add CDX bus device tree
bindings

[CAUTION: External Email]

On Tue, 06 Sep 2022 19:17:55 +0530, Nipun Gupta wrote:

quoted

This patch adds a devicetree binding documentation for CDX
bus.

CDX bus controller dynamically detects CDX bus and the
devices on these bus using CDX firmware.

Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
---
 .../devicetree/bindings/bus/xlnx,cdx.yaml     | 75 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++
 2 files changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/bus/xlnx,cdx.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:18.23-21.11:
Warning (unit_address_vs_reg): /example-0/smmu@ec000000: node has a unit
name, but no reg or ranges property
Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:23.22-30.11:
Warning (unit_address_vs_reg): /example-0/gic@e2000000: node has a unit
name, but no reg or ranges property
Documentation/devicetree/bindings/bus/xlnx,cdx.example.dts:26.35-29.15:
Warning (unit_address_vs_reg): /example-0/gic@e2000000/gic-its@e2040000:
node has a unit name, but no reg or ranges property
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
smmu@ec000000: $nodename:0: 'smmu@ec000000' does not match
'^iommu@[0-9a-f]*'
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
smmu@ec000000: 'reg' is a required property
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: $nodename:0: 'gic@e2000000' does not match '^interrupt-
controller(@[0-9a-f,]+)*$'
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: '#interrupt-cells' is a dependency of 'interrupt-controller'
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: 'reg' is a required property
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: gic-its@e2040000: False schema does not allow {'compatible':
['arm,gic-v3-its'], 'msi-controller': True, 'phandle': [[1]]}
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: gic-its@e2040000: '#msi-cells' is a required property
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: gic-its@e2040000: 'reg' is a required property
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
gic@e2000000: 'oneOf' conditional failed, one must be fixed:
        'interrupts' is a required property
        'interrupts-extended' is a required property
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/interrupt-controller/arm,gic-
v3.yaml
/builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.example.dtb:
cdx@4000000: reg: [[0, 67108864], [0, 4096]] is too long
        From schema: /builds/robherring/linux-dt-
review/Documentation/devicetree/bindings/bus/xlnx,cdx.yaml

doc reference errors (make refcheckdocs):

See
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
ork.ozlabs.org%2Fpatch%2F&data=05%7C01%7Cnipun.gupta%40amd.com
%7C47f53d11f4024ba765f408da902fc525%7C3dd8961fe4884e608e11a82d994e
183d%7C0%7C0%7C637980832144301226%7CUnknown%7CTWFpbGZsb3d8eyJ
WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
3000%7C%7C%7C&sdata=BXO1d2OWdCQ1lb%2BEDNiUvmfSPPfxfzJET%2B
uuAL9EdEY%3D&reserved=0

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

I did run make dt_binding_check, but did not see the issue.
Will update the dtschema and fix this.

Thanks,
Nipun

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel