[AMD Official Use Only - General]

-----Original Message-----
From: Marc Zyngier <maz@kernel.org>
Sent: Thursday, August 4, 2022 4:09 PM
To: Gupta, Nipun <Nipun.Gupta@amd.com>
Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
gregkh@linuxfoundation.org; rafael@kernel.org; tglx@linutronix.de;
okaya@kernel.org; Anand, Harpreet [off-list ref]; Simek,
Michal [off-list ref]; Agarwal, Nikhil
[off-list ref]
Subject: Re: [RFC PATCH 1/2] irqchip: cdx-bus: add cdx-MSI domain with gic-
its domain as parent

<snip>

quoted

quoted

quoted

+static int __init its_cdx_msi_init(void)
+{
+     its_cdx_of_msi_init();
+
+     return 0;
+}
+
+early_initcall(its_cdx_msi_init);

I really don't think we should have any more of this muck. Yes, the
other busses are also doing that, but here's our chance to do
something better.

Why can't the *bus* driver (I assume there is one) perform these
tasks? It would really help if this patch was shown in context,
because I have no idea how this fits in the grand scheme of things.

Agree, bus driver could do this stuff, and I was considering it too,
but as this was the norm so added these changes in this IRQ chip :).

Well, let's not miss this opportunity to improve things! :-)

quoted

Bus driver is not out yet, and we have pushed these as RFC changes
for early feedback (mentioned in the cover letter), but yes, these
patches would be clubbed as a part of overall changes.

And we can move it as a part of bus driver itself. I hope that suits?

It certainly sounds better than the above looks! Please Cc me on the
submission of this infrastructure.

Sounds good!! Then we will move this inside the bus infra itself and would
add you as a reviewer for the bus series.

Thanks,

        M.

--
Without deviation from the norm, progress is not possible.

On a lighter note, on the earlier mail I thought this was a comment for the
patch, as this change matches where norm is bus drivers adding domain in IRQ
chip, but now it seems this is the tagline you have :)

Thanks,
Nipun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel