Re: [PATCH v5 07/15] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings
From: Krzysztof Kozlowski <hidden>
Date: 2022-07-04 06:41:59
Also in:
linux-devicetree, linux-mmc, lkml
On 04/07/2022 01:50, Brad Larson wrote:
quoted
Missing file: ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': No such file or directory Send complete bindings, not parts of it. Did you test it? I am pretty sure that this did not happen. :(Its in patch v5-0015 with the driver
Header is part of bindings, not driver.
quoted hunk ↗ jump to hunk
. I'll check this, the correct approach should be put all binding changes as individual patches up front or there are exceptions for new driver. $ cat v5-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr.patch | grep diffdiff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile diff --git a/drivers/reset/reset-elbasr.c b/drivers/reset/reset-elbasr.c diff --git a/include/dt-bindings/reset/amd,pensando-elba-reset.hb/include/dt-bindings/reset/amd,pensando-elba-reset.h Yes, tested it with the following and no warnings or errors make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/amd,pensando.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml
So how this test could pass if there is no header file included in the example here? Are you sure you tested each commit separately (like it will be included in the kernel)? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel