Re: [PATCH v5 06/15] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip
From: Krzysztof Kozlowski <hidden>
Date: 2022-06-20 13:01:19
Also in:
linux-devicetree, linux-mmc, lkml
On 13/06/2022 21:56, Brad Larson wrote:
quoted hunk ↗ jump to hunk
From: Brad Larson <blarson@amd.com> Add support for the AMD Pensando Elba SoC System Resource chip using the SPI interface. The Elba SR is a Multi-function Device supporting device register access using CS0, smbus interface for FRU and board peripherals using CS1, dual Lattice I2C masters for transceiver management using CS2, and CS3 for flash access. Signed-off-by: Brad Larson <blarson@amd.com> --- .../bindings/mfd/amd,pensando-elbasr.yaml | 93 +++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yamldiff --git a/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml b/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml new file mode 100644 index 000000000000..13356800b1cf --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml@@ -0,0 +1,93 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/amd,pensando-elbasr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMD Pensando Elba SoC Resource Controller bindings + +description: | + AMD Pensando Elba SoC Resource Controller bindings attached to a SPI bus. + +maintainers: + - Brad Larson <blarson@amd.com> + +properties: + compatible: + items: + - enum: + - amd,pensando-elbasr + - const: simple-mfd + + spi-max-frequency: + description: Maximum SPI frequency of the device in Hz. + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - spi-max-frequency + +patternProperties: + '^reset-controller@[a-f0-9]+$': + $ref: ../reset/amd,pensando-elbasr-reset.yaml + +additionalProperties: false + +examples: + - | + #include <dt-bindings/reset/amd,pensando-elba-reset.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + spi0 {
Just "spi"
+ #address-cells = <1>;
+ #size-cells = <0>;
+ num-cs = <4>;
+
+ spi@0 {"spi" is for SPI controllers. Use generic name matching the device. Usually this is "system-controller", however Rob pointed out your inaccurate bindings and example.
+ compatible = "amd,pensando-elbasr", "simple-mfd";
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ spi-max-frequency = <12000000>;
+
+ rstc: reset-controller@0 {
+ compatible = "amd,pensando-elbasr-reset";
+ reg = <0>;
+ #reset-cells = <1>;
+ };
+ };
+
+ spi@1 {
+ compatible = "amd,pensando-elbasr", "simple-mfd";
+ reg = <1>;
+ spi-max-frequency = <12000000>;
+ };
+
+ spi@2 {
+ compatible = "amd,pensando-elbasr", "simple-mfd";
+ reg = <2>;
+ spi-max-frequency = <12000000>;
+ interrupt-parent = <&porta>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ spi@3 {
+ compatible = "amd,pensando-elbasr", "simple-mfd";
+ reg = <3>;
+ spi-max-frequency = <12000000>;
+ };
+ };
+
+...Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel