Re: [PATCH 06/18] KVM: arm64: Add three sets of flags to the vcpu state
From: Fuad Tabba <hidden>
Date: 2022-06-08 15:25:08
Also in:
kvm, kvmarm
Hi Marc, On Sat, May 28, 2022 at 12:38 PM Marc Zyngier [off-list ref] wrote:
It so appears that each of the vcpu flags is really belonging to one of three categories: - a configuration flag, set once and for all - an input flag generated by the kernel for the hypervisor to use - a state flag that is only for the kernel's own bookkeeping
I think that this division makes sense and simplifies reasoning about the state and what needs to be communicated to the hypervisor. I had a couple of minor nits, which I have already pointed out in the relevant patches. With that, patches 6~18: Reviewed-by: Fuad Tabba <redacted> Cheers, /fuad
quoted hunk ↗ jump to hunk
As we are going to split all the existing flags into these three sets, introduce all three in one go. No functional change other than a bit of bloat... Signed-off-by: Marc Zyngier <maz@kernel.org> --- arch/arm64/include/asm/kvm_host.h | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h index 5eb6791df608..c9dd0d4e22f2 100644 --- a/arch/arm64/include/asm/kvm_host.h +++ b/arch/arm64/include/asm/kvm_host.h@@ -338,6 +338,15 @@ struct kvm_vcpu_arch { /* Miscellaneous vcpu state flags */ u64 flags; + /* Configuration flags */ + u64 cflags; + + /* Input flags to the hypervisor code */ + u64 iflags; + + /* State flags, unused by the hypervisor code */ + u64 sflags; + /* * We maintain more than a single set of debug registers to support * debugging the guest from the host and to maintain separate host and --2.34.1 -- To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel