Thread (35 messages) 35 messages, 9 authors, 2022-01-26

Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI

From: Eric Biggers <ebiggers@kernel.org>
Date: 2022-01-26 22:54:32
Also in: linux-crypto, lkml, llvm

On Tue, Jan 25, 2022 at 01:23:34PM +0100, Jason A. Donenfeld wrote:
On 1/25/22, Eric Biggers [off-list ref] wrote:
quoted
On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote:
quoted
blake2s_compress_generic is weakly aliased by blake2s_generic. The
Don't you mean "weakly aliased by blake2s_compress"?
Grrrr. Thanks.
quoted
quoted
Changes v1->v2:
- Wrapped columns at 80 for Eric.
It is the recommended coding style, so not just for me :-)
I was under the impression this increased to 100 mid-2020 or so, and
checkpatch.pl now makes noise at that width instead.
From Documentation/process/coding-style.rst:

"The preferred limit on the length of a single line is 80 columns.

 Statements longer than 80 columns should be broken into sensible chunks,
 unless exceeding 80 columns significantly increases readability and does
 not hide information."

It's not as strict as it used to be, but checkpatch seems to be overly-lenient.
I always run it with --max-line-length=80.

- Eric

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help