Re: [PATCH] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI
From: Sami Tolvanen <samitolvanen@google.com>
Date: 2022-01-21 20:51:54
Also in:
linux-crypto, linux-mediatek, lkml
Hi Jason, On Fri, Jan 21, 2022 at 12:23 PM Jason A. Donenfeld [off-list ref] wrote:
On Fri, Jan 21, 2022 at 8:54 PM Eric Biggers [off-list ref] wrote:quoted
There are some lines over 80 columns in this patch.I'll fix that up.quoted
Otherwise this looks fine. It would be really nice to fix this in clang, though.I agree. I'm wondering whether it makes sense to roll with this patch, or to just not change anything and lean on Clang upstream to fix their bug. Full LTO is marked as "experimental" still. On the other hand, Android ships with it turned on, so how "experimental" can it really be? I don't have a strong read on the Clang ecosystem to know what makes most sense, to apply this or not. Do you have an opinion?
We'll work on fixing the compiler, but please note that it's most likely going to take a while, so I would prefer to work around the issue in the kernel for now. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel