Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI
From: Eric Biggers <ebiggers@kernel.org>
Date: 2022-01-25 08:01:42
Also in:
linux-crypto, lkml, llvm
On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote:
blake2s_compress_generic is weakly aliased by blake2s_generic. The
Don't you mean "weakly aliased by blake2s_compress"?
Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in")
Reported-by: Miles Chen <redacted>
Tested-by: Miles Chen <redacted>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Link: https://github.com/ClangBuiltLinux/linux/issues/1567
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---Otherwise this looks fine, though it's unfortunate this is needed. You can add: Reviewed-by: Eric Biggers [off-list ref]
Changes v1->v2: - Wrapped columns at 80 for Eric.
It is the recommended coding style, so not just for me :-) - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel