RE: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up

<snipped ...>

quoted

quoted

quoted

-static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) -{
-	clk_disable_unprepare(imx6_pcie->pcie);
-	clk_disable_unprepare(imx6_pcie->pcie_phy);
-	clk_disable_unprepare(imx6_pcie->pcie_bus);
-
-	switch (imx6_pcie->drvdata->variant) {
-	case IMX6SX:
-		clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
-		break;
-	case IMX7D:
-		regmap_update_bits(imx6_pcie->iomuxc_gpr,

IOMUXC_GPR12,

quoted

quoted

quoted

-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
-		break;
-	case IMX8MQ:
-		clk_disable_unprepare(imx6_pcie->pcie_aux);
-		break;
-	default:
-		break;

While you're at it, this "default: break;" thing is pointless.
Normally it's better to just *move* something without changing it at
all, but this is such a simple thing I think you could drop this at
the same time as the move.

[Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks.

[Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP.
 So I just don't drop them in v3 patch-set.

Best Regards
Richard Zhu

quoted

quoted

quoted

-	}
-}

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel