RE: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up

-----Original Message-----
From: Bjorn Helgaas <helgaas@kernel.org>
Sent: Saturday, October 16, 2021 2:52 AM
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de; bhelgaas@google.com;
lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
[off-list ref]; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; kernel@pengutronix.de
Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
unbalance when link never came up

On Fri, Oct 15, 2021 at 01:49:45PM -0500, Bjorn Helgaas wrote:

quoted

On Fri, Oct 15, 2021 at 02:05:40PM +0800, Richard Zhu wrote:

quoted

When link never came up, driver probe would be failed with error -110.
To keep usage counter balance of the clocks, disable the previous
enabled clocks when link is down.
Move definitions of the imx6_pcie_clk_disable() function to the
proper place. Because it wouldn't be used in imx6_pcie_suspend_noirq()

only.

quoted

quoted

-static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) -{
-	clk_disable_unprepare(imx6_pcie->pcie);
-	clk_disable_unprepare(imx6_pcie->pcie_phy);
-	clk_disable_unprepare(imx6_pcie->pcie_bus);
-
-	switch (imx6_pcie->drvdata->variant) {
-	case IMX6SX:
-		clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
-		break;
-	case IMX7D:
-		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
-		break;
-	case IMX8MQ:
-		clk_disable_unprepare(imx6_pcie->pcie_aux);
-		break;
-	default:
-		break;

While you're at it, this "default: break;" thing is pointless.
Normally it's better to just *move* something without changing it at all, but
this is such a simple thing I think you could drop this at the same time as the
move.

[Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks.

Best Regards
Richard Zhu

quoted

quoted

-	}
-}

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel