Re: [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding
From: Rob Herring <robh@kernel.org>
Date: 2021-10-01 13:18:04
Also in:
linux-devicetree, lkml
On Thu, 30 Sep 2021 19:04:03 -0500, Li Yang wrote:
When the binding was converted from txt to yaml, it actually added more constrains than the original txt binding which was already used in many in-tree DTSes. Some of the newly added constrains are either not valid or not neccessary. Not all SoCs use ipg as the clock name for i2c. There is no point in having SoC integration information defined in i2c binding. Remove the clock name requirement in the schema. The original txt binding didn't require the order of tx and rx for dmas/dma-names. Many in tree DTSes are already using the other order. Both orders should just work fine. Update the schema to allow both. Signed-off-by: Li Yang <redacted> --- v2: Updated the patch description Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1535099 i2c@21a4000: clock-frequency:0:0: 50000 is not one of [100000, 400000] arch/arm/boot/dts/imx6dl-alti6p.dt.yaml i2c@21f8000: clock-frequency:0:0: 50000 is not one of [100000, 400000] arch/arm/boot/dts/imx6dl-alti6p.dt.yaml i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000] arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml i2c@30a30000: clock-frequency:0:0: 387000 is not one of [100000, 400000] arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml i2c@30a40000: clock-frequency:0:0: 387000 is not one of [100000, 400000] arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml i2c@30a50000: clock-frequency:0:0: 387000 is not one of [100000, 400000] arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel