Thread (26 messages) flat view 26 messages, 4 authors, 2021-10-09
STALE1760d

Revision v2 of 3 in this series.

Revisions (3)
  1. v1 [diff vs current]
  2. v2 current
  3. v3 [diff vs current]

[PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding

From: Li Yang <hidden>
Date: 2021-10-01 00:04:35
Also in: linux-devicetree, lkml
Subsystem: freescale imx i2c driver, i2c subsystem host drivers, open firmware and flattened device tree bindings, the rest · Maintainers: Oleksij Rempel, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds

When the binding was converted from txt to yaml, it actually added more
constrains than the original txt binding which was already used in many
in-tree DTSes.  Some of the newly added constrains are either not valid
or not neccessary.

Not all SoCs use ipg as the clock name for i2c.  There is no point in
having SoC integration information defined in i2c binding.  Remove the
clock name requirement in the schema.

The original txt binding didn't require the order of tx and rx for
dmas/dma-names.  Many in tree DTSes are already using the other order.
Both orders should just work fine.  Update the schema to allow both.

Signed-off-by: Li Yang <redacted>
---
v2:
Updated the patch description

 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
index 3592d49235e0..da55d37a09a4 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
@@ -54,20 +54,20 @@ properties:
     maxItems: 1
 
   clock-names:
-    const: ipg
+    maxItems: 1
 
   clock-frequency:
     enum: [ 100000, 400000 ]
 
   dmas:
-    items:
-      - description: DMA controller phandle and request line for RX
-      - description: DMA controller phandle and request line for TX
+    minItems: 2
+    maxItems: 2
 
   dma-names:
+    minItems: 2
+    maxItems: 2
     items:
-      - const: rx
-      - const: tx
+      enum: [ "rx", "tx" ]
 
   sda-gpios:
     maxItems: 1
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help