Re: [PATCH v3 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe()
From: Jonathan Cameron <jic23@kernel.org>
Date: 2021-09-29 16:52:05
Also in:
linux-amlogic, linux-arm-msm, linux-iio, linux-rockchip, lkml
On Tue, 28 Sep 2021 22:19:54 +0800 Cai Huoqing [off-list ref] wrote:
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <redacted>
In this driver, there is also a call to devm_reset_control_get_exclusive() which I think can return -EPROBE_DEFER There isn't a message printed on that particular patch, but it would be good to add something generic. Same for platform_get_irq() There are some devm_clk_get() calls as well which likewise probably want handling in a similar fashion as you have done in other patches. Thanks, Jonathan
quoted hunk ↗ jump to hunk
--- v1->v2: Remove the separate line of PTR_ERR(). drivers/iio/adc/rockchip_saradc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c index a56a0d7337ca..57419ccb3c70 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c@@ -392,11 +392,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev) } info->vref = devm_regulator_get(&pdev->dev, "vref"); - if (IS_ERR(info->vref)) { - dev_err(&pdev->dev, "failed to get regulator, %ld\n", - PTR_ERR(info->vref)); - return PTR_ERR(info->vref); - } + if (IS_ERR(info->vref)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->vref), + "failed to get regulator\n"); if (info->reset) rockchip_saradc_reset_controller(info->reset);
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel