Thread (17 messages) 17 messages, 4 authors, 2021-10-02

Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()

From: Linus Walleij <hidden>
Date: 2021-09-28 14:30:41
Also in: linux-amlogic, linux-arm-msm, linux-iio, linux-rockchip, lkml

On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing [off-list ref] wrote:
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

BTW, change the return value from 'ENXIO' to 'ENODEV',
perfer ENODEV which means no such device.

Signed-off-by: Cai Huoqing <redacted>
---
v2->v3: Update the changelog.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help