Re: [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe()
From: Jonathan Cameron <jic23@kernel.org>
Date: 2021-09-29 16:16:53
Also in:
linux-amlogic, linux-arm-msm, linux-iio, linux-rockchip, lkml
On Tue, 28 Sep 2021 22:19:47 +0800 Cai Huoqing [off-list ref] wrote:
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Reviewed-by: Linus Walleij <redacted> Signed-off-by: Cai Huoqing <redacted>
I believe we could in theory get an -EPROBE_DEFER from platform_get_irq_by_name() so we should handle that one similarly. I have no idea if can actually happen on this platform, but seems to me that we should be thorough given how easy it is to do here. Thanks, Jonathan
quoted hunk ↗ jump to hunk
--- v1->v2: Remove the separate line of PTR_ERR(). drivers/iio/adc/ab8500-gpadc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c index 7b5212ba5501..c58d0e2ae538 100644 --- a/drivers/iio/adc/ab8500-gpadc.c +++ b/drivers/iio/adc/ab8500-gpadc.c@@ -1146,11 +1146,9 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) /* The VTVout LDO used to power the AB8500 GPADC */ gpadc->vddadc = devm_regulator_get(dev, "vddadc"); - if (IS_ERR(gpadc->vddadc)) { - ret = PTR_ERR(gpadc->vddadc); - dev_err(dev, "failed to get vddadc\n"); - return ret; - } + if (IS_ERR(gpadc->vddadc)) + return dev_err_probe(dev, PTR_ERR(gpadc->vddadc), + "failed to get vddadc\n"); ret = regulator_enable(gpadc->vddadc); if (ret) {
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel