Thread (27 messages) flat view 27 messages, 2 authors, 2021-08-02

Re: [boot-wrapper PATCH 01/12] Ensure `kernel_address` is aligned

From: Andre Przywara <andre.przywara@arm.com>
Date: 2021-07-30 15:15:05

On Thu, 29 Jul 2021 16:20:39 +0100
Mark Rutland [off-list ref] wrote:
We accidentally placed the `.align` directive after the `kernel_address`
label, meaning that the label itself isn't necessarily aligned. Place
the `.align` directive first to ensure this.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Ouch, good catch!

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre
quoted hunk ↗ jump to hunk
---
 arch/aarch64/spin.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/aarch64/spin.S b/arch/aarch64/spin.S
index 72603cf..ca05937 100644
--- a/arch/aarch64/spin.S
+++ b/arch/aarch64/spin.S
@@ -30,8 +30,8 @@ start_no_el3:
 	mov	x2, #0
 	bl	first_spin
 
-kernel_address:
 	.align 3
+kernel_address:
 	.long 0
 
 	.ltorg

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help