RE: [boot-wrapper PATCH 1/5] Decouple V2M_SYS config by auto-detect dtb node

Hi Andre,

-----Original Message-----
From: Andre Przywara <andre.przywara@arm.com>
Sent: Monday, April 26, 2021 7:30 PM
To: Jaxson Han <redacted>
Cc: Mark Rutland <Mark.Rutland@arm.com>; linux-arm-
kernel@lists.infradead.org; Wei Chen [off-list ref]
Subject: Re: [boot-wrapper PATCH 1/5] Decouple V2M_SYS config by auto-
detect dtb node

On Tue, 20 Apr 2021 15:24:34 +0800
Jaxson Han [off-list ref] wrote:

Hi,

quoted

An auto-detect switch is added to make it an option to enable/disable
'arm,vexpress-sysreg', because not all platforms support this feature.

The change itself is fine, only has the side effect of now printing an message
about the missing node:
No matching devices found at ./findbase.pl line 37.

I will have a look if we can avoid this, or we drop this message in findbase.pl
at all.

Thanks, if you have any suggestions, please let me know:)

But for the sake of this patch:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

Thanks!
Jaxson

quoted

Signed-off-by: Jaxson Han <redacted>
---
 Makefile.am | 2 +-
 platform.c  | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am index af694b7..e131207 100644
--- a/Makefile.am
+++ b/Makefile.am

@@ -19,7 +19,7 @@ NR_CPUS         := $(shell echo $(CPU_IDS) | tr ',' ' ' | wc

-w)

quoted

 DEFINES		= -DCNTFRQ=$(CNTFRQ)
 DEFINES		+= -DCPU_IDS=$(CPU_IDS)
 DEFINES		+= -DNR_CPUS=$(NR_CPUS)
-DEFINES		+= -DSYSREGS_BASE=$(SYSREGS_BASE)
+DEFINES		+= $(if $(SYSREGS_BASE), -

DSYSREGS_BASE=$(SYSREGS_BASE), )

quoted

 DEFINES		+= -DUART_BASE=$(UART_BASE)
 DEFINES		+= -DSTACK_SIZE=256

diff --git a/platform.c b/platform.c
index a528a55..d11f568 100644
--- a/platform.c
+++ b/platform.c

@@ -23,10 +23,12 @@

 #define PL011(reg)	((void *)UART_BASE + PL011_##reg)

+#ifdef SYSREGS_BASE
 #define V2M_SYS_CFGDATA		0xa0
 #define V2M_SYS_CFGCTRL		0xa4

 #define V2M_SYS(reg)	((void *)SYSREGS_BASE + V2M_SYS_##reg)
+#endif

 static void print_string(const char *str)  { @@ -59,6 +61,7 @@ void

init_platform(void)

 	print_string("Boot-wrapper v0.2\r\n\r\n");

+#ifdef SYSREGS_BASE
 	/*
 	 * CLCD output site MB
 	 */

@@ -66,4 +69,5 @@ void init_platform(void)
 	/* START | WRITE | MUXFPGA | SITE_MB */
 	raw_writel((1 << 31) | (1 << 30) | (7 << 20) | (0 << 16),
 				V2M_SYS(CFGCTRL));
+#endif
 }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel