Re: [PATCH v2 03/13] spi: dw: Add support for Pensando Elba SoC SPI

On Mon, Mar 29, 2021 at 8:58 AM Mark Brown [off-list ref] wrote:

On Sun, Mar 28, 2021 at 06:59:28PM -0700, Brad Larson wrote:

quoted

@@ -56,7 +56,7 @@ struct dw_spi_mscc {
 /*
  * The Designware SPI controller (referred to as master in the documentation)
  * automatically deasserts chip select when the tx fifo is empty. The chip
- * selects then needs to be either driven as GPIOs or, for the first 4 using the
+ * selects then needs to be either driven as GPIOs or, for the first 4 using
  * the SPI boot controller registers. the final chip select is an OR gate
  * between the Designware SPI controller and the SPI boot controller.
  */

This is an unrelated fix, please send as a separate patch as covered in
submitting-patches.rst.

I'll remove this.  Belongs in a trivial patch set.

quoted

@@ -237,6 +237,31 @@ static int dw_spi_canaan_k210_init(struct platform_device *pdev,
      return 0;
 }

+static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
+{
+     struct dw_spi *dws = spi_master_get_devdata(spi->master);
+
+     if (!enable) {
+             /*
+              * Using a GPIO-based chip-select, the DW SPI
+              * controller still needs its own CS bit selected
+              * to start the serial engine.  On Elba the specific
+              * CS doesn't matter to start the serial engine,
+              * so using CS0.
+              */

Why does this comment only apply to one branch of the conditional?

It doesn't, I'll move it outside the conditional.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel