Re: [PATCH v2 13/13] gpio: Use linux/gpio/driver.h
From: Brad Larson <hidden>
Date: 2021-03-30 02:21:14
Also in:
linux-devicetree, linux-gpio, linux-mmc, linux-spi, lkml
On Sun, Mar 28, 2021 at 11:48 PM Greg KH [off-list ref] wrote:
On Sun, Mar 28, 2021 at 06:59:38PM -0700, Brad Larson wrote:quoted
New drivers should include <linux/gpio/driver.h> instead of legacy <linux/gpio.h>. Signed-off-by: Brad Larson <redacted> --- drivers/gpio/gpio-elba-spics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c index 351bbaeea033..c0dce5333f35 100644 --- a/drivers/gpio/gpio-elba-spics.c +++ b/drivers/gpio/gpio-elba-spics.c@@ -6,11 +6,10 @@ */ #include <linux/err.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/module.h> #include <linux/io.h> #include <linux/init.h> -//#include <linux/of.h> #include <linux/platform_device.h> #include <linux/spinlock.h> #include <linux/types.h> --2.17.1This should be part of patch 1/13, do not add a problem and then fix it up in the same patch series. thanks, greg k-h
Yes, thanks. I'm laughing at myself today looking at that patch tagged at the end. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel