Re: [PATCH v2 03/13] spi: dw: Add support for Pensando Elba SoC SPI
From: Andy Shevchenko <hidden>
Date: 2021-03-29 10:44:18
Also in:
linux-devicetree, linux-gpio, linux-mmc, linux-spi, lkml
On Mon, Mar 29, 2021 at 5:01 AM Brad Larson [off-list ref] wrote:
The Pensando Elba SoC uses a GPIO based chip select for two DW SPI busses with each bus having two chip selects.
...
+static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
+{
+ struct dw_spi *dws = spi_master_get_devdata(spi->master);
+
+ if (!enable) {Can you use positive conditional?
+ /*
+ * Using a GPIO-based chip-select, the DW SPI
+ * controller still needs its own CS bit selected
+ * to start the serial engine. On Elba the specific
+ * CS doesn't matter to start the serial engine,
+ * so using CS0.
+ */
+ dw_writel(dws, DW_SPI_SER, BIT(0));
+ } else {
+ dw_writel(dws, DW_SPI_SER, 0);
+ }
+}-- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel