Thread (67 messages) 67 messages, 5 authors, 2021-02-28

Re: [PATCH v8 12/22] counter: Rename counter_count_function to counter_function

From: David Lechner <david@lechnology.com>
Date: 2021-02-20 16:57:08
Also in: linux-iio, lkml

On 2/14/21 11:13 AM, Jonathan Cameron wrote:
On Fri, 12 Feb 2021 21:13:36 +0900
William Breathitt Gray [off-list ref] wrote:
quoted
The phrase "Counter Count function" is verbose and unintentionally
implies that function is a Count extension. This patch adjusts the
Counter subsystem code to use the more direct "Counter function" phrase
to make the intent of this code clearer. The phrase "Count action" is
adjusted herein as well for the same reason.

Cc: Syed Nayyar Waris <redacted>
Cc: Patrick Havelange <patrick.havelange@essensium.com>
Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: Fabrice Gasnier <redacted>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <redacted>
Cc: David Lechner <david@lechnology.com>
Signed-off-by: William Breathitt Gray <redacted>
I agree this makes sense in the counter core code, but in the drivers
it may not be quite so obvious we are talking about a counter function
given some of the bits of hardware do a number of other things.

I guess up to the various driver maintainers on whether they
think the new meaning is clear enough!

Jonathan
TBH, I think "counter count function" makes more sense to me.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help