Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360

On Thu 2020-09-10 14:34:54, Andy Shevchenko wrote:

On Thu, Sep 10, 2020 at 11:18 AM Pavel Machek [off-list ref] wrote:

...

quoted

quoted

quoted

quoted

+enum {
+       MT6360_LED_ISNK1 = 0,
+       MT6360_LED_ISNK2,
+       MT6360_LED_ISNK3,
+       MT6360_LED_ISNK4,
+       MT6360_LED_FLASH1,
+       MT6360_LED_FLASH2,

quoted

+       MT6360_MAX_LEDS,

No comma for terminator entry.

ACK

Actually, that comma is fine. Its absence would be fine, too.

It is slightly better not to have to prevent (theoretical) rebase or
other similar issues when a new item can go behind the terminator. In
such a case compiler can easily tell you if something is wrong.

Okay, I see your point.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html