Re: [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED
From: Dan Murphy <hidden>
Date: 2020-09-08 19:55:39
Also in:
linux-devicetree, linux-leds, linux-mediatek, lkml
Gene On 9/7/20 5:27 AM, Gene Chen wrote:
quoted hunk ↗ jump to hunk
From: Gene Chen <redacted> Add bindings document for LED support on MT6360 PMIC Signed-off-by: Gene Chen <redacted> --- .../devicetree/bindings/leds/leds-mt6360.yaml | 105 +++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yamldiff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file mode 100644 index 0000000..72914c6 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml@@ -0,0 +1,105 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6360 PMIC from MediaTek Integrated. + +maintainers: + - Gene Chen <gene_chen@richtek.com> + +description: | + This module is part of the MT6360 MFD device. + The LED controller is represented as a sub-node of the PMIC node on + the device tree. + This device has six current sinks. +
A bit of a nitpick but wouldn't the commit message in patch 1/2 be a better description of the hardware then this? Other wise Reviewed-by: Dan Murphy <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel