Thread (30 messages) 30 messages, 6 authors, 2020-07-24

Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate

From: Maxime Ripard <hidden>
Date: 2020-07-23 16:56:31
Also in: linux-pm, lkml

On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote:
On 20/07/2020 11:27, Frank Lee wrote:
quoted
HI,
On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano
[off-list ref] wrote:
quoted
On 17/07/2020 09:35, Frank Lee wrote:
quoted
On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
[off-list ref] wrote:
quoted
On 14/07/2020 09:13, Frank Lee wrote:
quoted
From: Yangtao Li <redacted>

For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
calculation. On the other hand, the newer SOC may store other data in
the space other than 12bit sensor data. Add mask operation to read data
to avoid conversion error.

Signed-off-by: Yangtao Li <redacted>
Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>
Can you clarify these SoB ?
Previously I used 'Signed-off-by: Yangtao Li [off-list ref]',
maybe this should be removed directly?
quoted
Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ?
Yeah.
You are not supposed to add reviewed-by yourself. Please remove it.
Should I resend the entire series or just the thermal patch?
What about those that have been applied.
I can not speak on behalf of other maintainers.

The simplest would be to ask them directly.

If you want to go forward with the thermal changes, you can send them
separately but Maxim's Ack will be needed anyway.
Given that I had a few other comments on the other patches, I guess you
can resend the whole series, it will be simpler to track down.

Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help