On 17/07/2020 09:35, Frank Lee wrote:

On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
[off-list ref] wrote:

quoted

On 14/07/2020 09:13, Frank Lee wrote:

quoted

From: Yangtao Li <redacted>

For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
calculation. On the other hand, the newer SOC may store other data in
the space other than 12bit sensor data. Add mask operation to read data
to avoid conversion error.

Signed-off-by: Yangtao Li <redacted>
Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>

Can you clarify these SoB ?

Previously I used 'Signed-off-by: Yangtao Li [off-list ref]',
maybe this should be removed directly?

quoted

Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ?

Yeah.

You are not supposed to add reviewed-by yourself. Please remove it.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel