Re: [PATCH 18/23] memory: mtk-smi: Add argument to function definition
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-07-23 08:55:41
Also in:
linux-mediatek, linux-omap, linux-tegra, lkml
On Thu, Jul 23, 2020 at 10:50:08AM +0200, Arnd Bergmann wrote:
On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski [off-list ref] wrote:quoted
Fix checkpatch warning: WARNING: function definition argument 'struct device *' should also have an identifier name Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>Is this a bug in checkpatch? I don't see why it should warn about this, as there is no function definition here. Your change is clearly harmless, but I wonder if we should fix checkpatch instead.
Good point. If this were not a warning, I would ignore it. However still the common practice is to add arguments to such type definitions as it helps to describe the type. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel