Re: [PATCH 18/23] memory: mtk-smi: Add argument to function definition
From: Arnd Bergmann <arnd@arndb.de>
Date: 2020-07-23 08:50:29
Also in:
linux-mediatek, linux-omap, linux-tegra, lkml
On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski [off-list ref] wrote:
Fix checkpatch warning:
WARNING: function definition argument 'struct device *' should also have an identifier name
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Is this a bug in checkpatch? I don't see why it should warn about this,
as there is no function definition here.
Your change is clearly harmless, but I wonder if we should fix
checkpatch instead.
Arnd
quoted hunk ↗ jump to hunk
--- drivers/memory/mtk-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index 109c7e51d551..c21262502581 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c@@ -60,7 +60,7 @@ struct mtk_smi_common_plat { struct mtk_smi_larb_gen { int port_in_larb[MTK_LARB_NR_MAX + 1]; - void (*config_port)(struct device *); + void (*config_port)(struct device *dev); unsigned int larb_direct_to_common_mask; bool has_gals; }; --2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel