On Fri, Jun 5, 2020 at 12:14 AM Michael Walle [off-list ref] wrote:

Add support for the hardware monitoring controller of the sl28cpld board
management controller. This driver is part of a multi-function device.

...

+#include <linux/of_device.h>

mod_devicetable.h ?

...

+       hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev,
+                               "sl28cpld_hwmon", hwmon,
+                               &sl28cpld_hwmon_chip_info, NULL);
+       if (IS_ERR(hwmon_dev)) {
+               dev_err(&pdev->dev, "failed to register as hwmon device");

+               return PTR_ERR(hwmon_dev);
+       }
+
+       return 0;

PTR_ERR_OR_ZERO() ?

...

+static const struct of_device_id sl28cpld_hwmon_of_match[] = {
+       { .compatible = "kontron,sl28cpld-fan" },

+       {},

No comma.

+};

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel