On Fri, Jun 5, 2020 at 12:16 AM Michael Walle [off-list ref] wrote:

Add the core support for the board management controller found on the
SMARC-sAL28 board. It consists of the following functions:
 - watchdog
 - GPIO controller
 - PWM controller
 - fan sensor
 - interrupt controller

At the moment, this controller is used on the Kontron SMARC-sAL28 board.

Please note that the MFD driver is defined as bool in the Kconfig
because the next patch will add interrupt support.

...

+config MFD_SL28CPLD
+       bool "Kontron sl28 core driver"
+       depends on I2C=y

Why not module?

+       depends on OF

I didn't find an evidence this is needed.

No Compile Test?

+       select REGMAP_I2C
+       select MFD_CORE

...

+#include <linux/of_platform.h>

No evidence of user of this.
I think you meant mod_devicetable.h.

...

+static struct i2c_driver sl28cpld_driver = {
+       .probe_new = sl28cpld_probe,
+       .driver = {
+               .name = "sl28cpld",
+               .of_match_table = of_match_ptr(sl28cpld_of_match),

Drop of_match_ptr(). It has a little sense in this context (depends OF).
It will have a little sense even if you drop depends OF b/c you will
introduce a compiler warning.

+       },
+};

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel