On Fri, Jun 5, 2020 at 1:24 PM Michael Walle [off-list ref] wrote:

Am 2020-06-05 10:14, schrieb Andy Shevchenko:

quoted

On Fri, Jun 5, 2020 at 12:14 AM Michael Walle [off-list ref] wrote:

...

quoted

quoted

+static bool nowayout = WATCHDOG_NOWAYOUT;
+module_param(nowayout, bool, 0);
+MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started
(default="
+                               __MODULE_STRING(WATCHDOG_NOWAYOUT)
")");
+
+static int timeout;
+module_param(timeout, int, 0);
+MODULE_PARM_DESC(timeout, "Initial watchdog timeout in seconds");

Guenter ACKed this, but I'm wondering why we still need module
parameters...

How would a user change the nowayout or the timeout? For the latter
there is
a device tree entry, but thats not easy changable by the user.

Yes, it's more question to VIm and Guenter than to you.

...

quoted

quoted

+       if (status & WDT_CTRL_EN) {
+               sl28cpld_wdt_start(wdd);

quoted

+               set_bit(WDOG_HW_RUNNING, &wdd->status);

Do you need atomic op here? Why?

I'd say consistency, all watchdog drivers do it like that. I just
had a look at where this is used, but it looks like access from
userspace is protected by a lock.

Okay then.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel