Thread (46 messages) 46 messages, 2 authors, 2020-05-28

Re: [PATCH v6 17/18] mtd: rawnand: Write a compatibility layer

From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2020-05-28 14:53:28
Also in: linux-devicetree

Boris Brezillon [off-list ref] wrote on Thu, 28 May
2020 16:42:17 +0200:
On Thu, 28 May 2020 13:31:12 +0200
Miquel Raynal [off-list ref] wrote:
quoted
+static enum nand_ecc_engine_type
+of_get_rawnand_ecc_engine_type_legacy(struct device_node *np)
+{
+	enum nand_ecc_legacy_mode {
+		NAND_ECC_INVALID,
+		NAND_ECC_NONE,
+		NAND_ECC_SOFT,
+		NAND_ECC_SOFT_BCH,
+		NAND_ECC_HW,
+		NAND_ECC_HW_SYNDROME,
+		NAND_ECC_ON_DIE,
+	};  
You're redefining an enum, but I don't see the old enum/defines being
removed, is that expected?
Oh yeah, my desire was to get rid of this public enumeration and mov it
to the single legacy function using it, but indeed I am removing it in
the next patch as part of the global move to nand/core.c. I will do it
in this patch.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help