Re: [RESEND v6 06/13] spi: imx: fix ERR009165
From: Uwe Kleine-König <hidden>
Date: 2020-03-10 08:37:44
Also in:
dmaengine, linux-devicetree, linux-spi, lkml
Hello, On Tue, Mar 10, 2020 at 08:27:41AM +0000, Robin Gong wrote:
On 2020/03/10 Sascha Hauer [off-list ref] wrote:quoted
On Tue, Mar 10, 2020 at 07:31:55PM +0800, Robin Gong wrote:quoted
writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);@@ -612,12 +613,14 @@ static int mx51_ecspi_prepare_transfer(structspi_imx_data *spi_imx, static void mx51_setup_wml(struct spi_imx_data *spi_imx) { + u32 tx_wml = 0; + /* * Configure the DMA register: setup the watermark * and enable DMA request. */ writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) | - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) | + MX51_ECSPI_DMA_TX_WML(tx_wml) |tx_wml is never assigned any other value than 0. Drop the variable.That's prepared for 07/13 patch which may assign spi_imx->wml to tx_wml.
Then this belongs into patch 7, right? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel