Re: [PATCH 3/3] PCI: brcmstb: Drop clk_put when probe fails and remove
From: Nicolas Saenz Julienne <hidden>
Date: 2020-02-14 10:55:43
Also in:
linux-gpio, linux-pci
On Thu Feb 13, 2020 at 11:59 AM, Jaedon Shin wrote:
devm_clk_get* APIs are device managed and get freed automatically when the device detaches. so there is no reason to explicitly call clk_put() in probe or remove functions. Signed-off-by: Jaedon Shin <redacted> ---
Acked-by: Nicolas Saenz Julienne <redacted> Thanks!
quoted hunk ↗ jump to hunk
drivers/pci/controller/pcie-brcmstb.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/pci/controller/pcie-brcmstb.cb/drivers/pci/controller/pcie-brcmstb.c index 0e0ca39a680b..3e48d9e238bb 100644--- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c@@ -972,7 +972,6 @@ static void __brcm_pcie_remove(struct brcm_pcie*pcie) brcm_pcie_turn_off(pcie); brcm_pcie_regulator_disable(pcie); clk_disable_unprepare(pcie->clk); - clk_put(pcie->clk); } static int brcm_pcie_remove(struct platform_device *pdev) -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel