Thread (18 messages) 18 messages, 4 authors, 2020-01-15

Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings

From: Hanjie Lin <hidden>
Date: 2020-01-10 01:27:26
Also in: linux-amlogic, linux-devicetree, linux-usb


On 2020/1/10 1:12, Martin Blumenstingl wrote:
On Thu, Jan 9, 2020 at 3:30 AM Hanjie Lin [off-list ref] wrote:
[...]
quoted
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: xtal_usb_phy
the "usb_phy" part of "xtal_usb_phy" seems redundant to me:
it's the XTAL clock input (this is what I'd expect as clock-name) of
the USB PHY (this is already part of the node name).
in addition to keeping the reset-names consistent (as Neil suggested)
please also use the same clock-names as G12
Of course.

I will use "xtal" name in next version.

Thanks,
Hanjie
Thank you!
Martin

.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help