On Fri, Sep 13, 2019 at 3:12 AM Sudeep Holla [off-list ref] wrote:

On Thu, Sep 12, 2019 at 03:48:47AM +0530, Amit Kucheria wrote:

quoted

Push various VEXPRESS drivers behind ARCH_VEXPRESS dependency so that it
doesn't get enabled by default on other platforms.

I couldn't understand the motivation for these changes from the cover letter.

Yes, the cover letter for this series needs to be a lot better. Sorry.
In summary, I found a bunch of drivers in defconfig that were getting
called in early_initcall and core_initcall even when the platform or
COMPILE_TEST was not enabled. So I was just trying to ring fence some
of those drivers as a proof of concept to see if these changes were
acceptable upstream.

Let me try again with a better cover letter and using the pattern Arnd
suggested elsewhere.

quoted

Signed-off-by: Amit Kucheria <redacted>
---
 drivers/bus/Kconfig           | 2 +-
 drivers/clk/versatile/Kconfig | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index d80e8d70bf10..b2b1beee9953 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig

@@ -166,7 +166,7 @@ config UNIPHIER_SYSTEM_BUS

 config VEXPRESS_CONFIG
      bool "Versatile Express configuration bus"
-     default y if ARCH_VEXPRESS
+     depends on ARCH_VEXPRESS
      depends on ARM || ARM64
      depends on OF
      select REGMAP

diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
index ac766855ba16..826750292c1e 100644
--- a/drivers/clk/versatile/Kconfig
+++ b/drivers/clk/versatile/Kconfig

@@ -5,8 +5,8 @@ config ICST
 config COMMON_CLK_VERSATILE
      bool "Clock driver for ARM Reference designs"
      depends on ARCH_INTEGRATOR || ARCH_REALVIEW || \
-             ARCH_VERSATILE || ARCH_VEXPRESS || ARM64 || \
-             COMPILE_TEST
+             ARCH_VERSATILE || ARCH_VEXPRESS || COMPILE_TEST
+     depends on ARM64

This will break 32-bit platforms.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel