Re: [PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies
From: Arnd Bergmann <arnd@arndb.de>
Date: 2019-09-12 09:23:47
Also in:
linux-clk, linux-gpio, linux-pci, linux-pm, lkml
On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Push various XGENE drivers behind ARCH_XGENE dependency so that it doesn't get enabled by default on other platforms. Signed-off-by: Amit Kucheria <redacted> --- arch/arm64/Kconfig.platforms | 3 +++ drivers/clk/Kconfig | 2 +- drivers/gpio/Kconfig | 1 + drivers/pci/controller/Kconfig | 1 + drivers/phy/Kconfig | 1 + drivers/power/reset/Kconfig | 2 +- 6 files changed, 8 insertions(+), 2 deletions(-)diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 4778c775de1b..cdf4e452e34c 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms@@ -281,6 +281,9 @@ config ARCH_VULCAN config ARCH_XGENE bool "AppliedMicro X-Gene SOC Family" + select COMMON_CLK_XGENE + select PCI_XGENE + select GPIO_XGENE help This enables support for AppliedMicro X-Gene SOC Family
I'd rather not 'select' drivers that might be optional, the 'default y' should be sufficient as long as it's in theory possible to have them disabled or as loadable modules.
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 801fa1cd0321..9b2790d3f18a 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig@@ -225,7 +225,7 @@ config CLK_QORIQ config COMMON_CLK_XGENE bool "Clock driver for APM XGene SoC" - default ARCH_XGENE + depends on ARCH_XGENE depends on ARM64 || COMPILE_TEST ---help--- Sypport for the APM X-Gene SoC reference, PLL, and device clocks.
This breaks compile-testing, and existing defconfigs
that don't list the driver.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel