Thread (25 messages) 25 messages, 3 authors, 2019-06-08

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

From: Dragan Cvetic <hidden>
Date: 2019-06-07 10:58:39
Also in: linux-devicetree, lkml

On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote:
quoted
+static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
+{
+	return 0;
+}
+
+static int xsdfec_dev_release(struct inode *iptr, struct file *fptr)
+{
+	return 0;
+}
empty open/close functions are never needed, just drop them.
open() is needed to allocate file descriptor eg.
fd = open(dev_name, O_RDWR);

Please, advise if you have some other idea in mind

Thanks
Dragan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help