Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2019-06-06 13:26:33
Also in:
linux-devicetree, lkml
On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote:
quoted hunk ↗ jump to hunk
Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic <redacted> Signed-off-by: Derek Kiernan <redacted> Signed-off-by: Dragan Cvetic <redacted> --- drivers/misc/xilinx_sdfec.c | 57 +++++++++++++++++++++++++++++++++++++--- include/uapi/misc/xilinx_sdfec.h | 4 +++ 2 files changed, 58 insertions(+), 3 deletions(-)diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index ff32d29..740b487 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c@@ -51,7 +51,6 @@ struct xsdfec_clks { * @regs: device physical base address * @dev: pointer to device struct * @config: Configuration of the SDFEC device - * @open_count: Count of char device being opened
Why is this removed here? You don't add something in one patch and then remove it in a later one if it's never needed :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel